ESA JWST Migration to PyVO#3592
Open
jespinosaar wants to merge 18 commits into
Open
Conversation
…upload endpoint ingestion
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3592 +/- ##
==========================================
- Coverage 73.23% 73.20% -0.03%
==========================================
Files 226 225 -1
Lines 21010 21055 +45
==========================================
+ Hits 15386 15413 +27
- Misses 5624 5642 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
We will work next week on increasing the coverage. In the meantime, we can start having a look at this PR, many thanks! |
Contributor
Author
|
It seems all the checks are passing now, except for the oldest version for all dependencies. This seems to be an unrelated error. Please let me know if you have any comment. Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Astroquery team,
This PR is an upgrade of the ESA JWST module, replacing the previous TAP implementation with the newest one based on PyVO, already applied to other Archives.
With this, code has been cleaned and classes are now making use of the EsaTap class. Together with this, now we have added the possibility of uploading tables.
Thanks to @lmasselo for doing this! Please add her to the list of contributors as well (we currently have a lot of people working on Astroquery).
Please let us know if you have any comment.
Kind regards,
jespinosa